[tor-bugs] #31705 [Core Tor/Tor]: Add sufficient coccinelle tooling to run coccinelle without stress
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Oct 1 14:07:04 UTC 2019
#31705: Add sufficient coccinelle tooling to run coccinelle without stress
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: task | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 042-can | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Design review:
The design and overall structure looks good. I am not that familiar with
coccinelle, so I will need to run these scripts myself as part of my
review.
Should we be running these scripts as part of our code quality checks?
(We could install coccinelle on Travis, so it runs them.)
Is that a separate ticket?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31705#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list