[tor-bugs] #31794 [Circumvention/Snowflake]: Errors swallowed

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 1 00:34:02 UTC 2019


#31794: Errors swallowed
-------------------------------------+--------------------------------
 Reporter:  sah                      |          Owner:  (none)
     Type:  defect                   |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+--------------------------------

Comment (by sah):

 >> Might as well be consistent. Looks like ​this error message is still
 capitalized.
 Line 47 is a log message, and not an error. If it is to be changed, then
 line 45 will need to be changed as well.

 I've updated the error message, moved the change to the increments to the
 correct commit, and updated the socksAcceptLoop to not return an error.
 Note: In that method the return would have terminated the loop, so I have
 replaced it with a break statement (as well as a log statement).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31794#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list