[tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  sysrqb
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:8 gk]:
 > Replying to [comment:6 sysrqb]:
 > > Okay, i think option (3) is the more simple. We only need `./mach
 android assemble-app`. I also filtered `mk` from the locale list. Branch
 `bug32365_02`.
 >
 > Thanks! I assume the change got introduced in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1443208 and looking at that
 bug your patch looks good. However, I don't think we should filter `mk` as
 you do. *If* we do the filtering no `mk` content is shown. But if we don't
 do it then at least the Torbutton parts (like the `about:tor` page) *are*
 localized if you have an `mk` device. I'd argue that is a win. We probably
 should put a comment above the part where you filtered `mk` as this
 behavior is not obvious.

 That makes sense. I created a new branch reflecting these changes.
 `bug32365_03`

 >
 > What bothers me is that the locale is still not properly propagated to
 our `about:tor` page and fundraising parts. It's just the default link
 that's visible unless you switch the locale. But then after restart you
 see the same again. We should file a ticket for that and get this fixed
 for the next release.

 I debugged this. It is cause by two problems.

 1. In `aboutTor-content.js`:`onPageLoad` we only track changes of
 `intl.locale.os`, however, in Fennec the locale may be set by either
 `intl.locale.os` or `intl.locale.requested`.

 1. When `about:tor` is loaded, `onLocaleChange` is called before
 `onChromeDataUpdate`, therefore the
 `content.document.body.getAttribute("mobile")` conditional in
 `onLocaleChange` is always `undefined` at the first page load.

 I opened #32628 for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32365#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online