[tor-bugs] #32613 [Core Tor/Tor]: Simple tests for checkSpaces.pl

[Tor Bug Tracker & Wiki]

#32613: Simple tests for checkSpaces.pl
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  task          |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .1
Parent ID:  #32522        |         Points:  .1
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:1 nickm]:
 > I have a test as ticket32613 with PR at
 https://github.com/torproject/tor/pull/1569

 Looks fine, please fix a typo in a function name.

 > This isn't automated, since we only need to run it when we change our
 checkSpace.pl script.

 I think we should run it in "make check" (CI), and the commit hook for
 these reasons:
 * it's fast
 * if the CI environment breaks, it's important to have known-good tests
 for diagnostics
 * CI helps us make sure that any changes work on Linux and macOS, across a
 variety of environments
 * we're going to change this script at least three times in the next few
 months, in #32610, #29226 (perhaps multiple times), and when we replace it
 with python
 * developers don't usually remember to run extra tests :-)

 And skipping Windows is easy, we have plenty of scripts that do that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32613#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online