[tor-bugs] #32610 [Core Tor/Tor]: Add macro spacing checks to "make check-spaces"

[Tor Bug Tracker & Wiki]

#32610: Add macro spacing checks to "make check-spaces"
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  teor
     Type:  enhancement                    |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.3.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  0.4
Parent ID:  #32522                         |         Points:  0.2
 Reviewer:  nickm                          |        Sponsor:  Sponsor31-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I fixed the patch so all 4 lists of Tor C files are consistent.

 Replying to [comment:4 nickm]:
 > (Before we spend too much time on this, let's also make sure it's
 something that our code autoformatter won't take care of for us, so that
 the effort isn't redundant)

 I think we're still some time away from automated C formatting. We should
 trial `make autostyle` first, see #31713. I think I finally fixed the last
 few instances of #31891 on Monday.

 I discovered these issues during #32522, I don't expect to spend any more
 time on check-spaces. It is an improvement, and it shouldn't take much
 time to review.

 I suggest we merge now, and then remove redundant (or conflicting) parts
 of check-spaces when we implement C autoformatting?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32610#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online