[tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

[Tor Bug Tracker & Wiki]

#32500: consider clang -std=gnu99 in Travis for better C99 portability
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.3
  035-backport, 040-backport, 041-backport,      |
  042-backport                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Further investigation reveals that `check-cocci` probably hasn't ever
 worked on Trusty because of an older version of coccinelle that has a
 harder time parsing our files.

 It looks like the setting of `env: C_DIALECT_OPTIONS="-std=gnu99"` in
 `.travis.yml` overrode the the existing `env: CHUTNEY="yes"
 CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes"` in that matrix entry,
 which likely caused `make check-cocci` to run for the first time on
 Trusty, unmasking a latent failure. (See https://travis-
 ci.org/tlyu/tor/builds/617437732 for a diagnostic.) The other Linux matrix
 entries run on Bionic.

 So we should probably attach the `gcc -std=gnu99` variant to a different
 matrix entry.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32500#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online