[tor-bugs] #32581 [Core Tor/Tor]: Turn on clang's -Wtype-safety to detect fnctl() and ioctl() errors

[Tor Bug Tracker & Wiki]

#32581: Turn on clang's -Wtype-safety to detect fnctl() and ioctl() errors
------------------------------+----------------------------------
 Reporter:  teor              |          Owner:  (none)
     Type:  enhancement       |         Status:  new
 Priority:  Medium            |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor      |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  code-correctness  |  Actual Points:
Parent ID:                    |         Points:  0.5
 Reviewer:                    |        Sponsor:
------------------------------+----------------------------------

Comment (by nickm):

 We have this already in our list of warnings that we enable if they are
 present:
 {{{
      -Wtentative-definition-incomplete-type
      -Wtrampolines
      -Wtype-safety
      -Wtypedef-redefinition
 }}}

 When I build with clang, it's in my warning_flags file:
 {{{
 ...-Wtentative-definition-incomplete-type -Wtype-safety -Wtypedef-
 redefinition -Wtypename-missing...
 }}}

 I think we already do this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32581#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online