[tor-bugs] #32475 [Applications/Tor Browser]: Reduce the number of locales we provide updates for in nightly

[Tor Bug Tracker & Wiki]

#32475: Reduce the number of locales we provide updates for in nightly
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  boklm
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-update,                 |  Actual Points:
  TorBrowserTeam201911, ux-team                  |
Parent ID:  #18867                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor9
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-update, TorBrowserTeam201911R, ux-team => tbb-
     rbm, tbb-update, TorBrowserTeam201911, ux-team


Comment:

 Replying to [comment:12 boklm]:
 > Replying to [comment:11 gk]:
 > > Replying to [comment:10 boklm]:
 > > > I pushed a new revision of the patch in branch `bug_32475_v3`:
 > > > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32475_v3&id=0327f0a0676d6a377f4f8b042bb5d34247d9cd94
 > > >
 > > > This removes the hack that was used to check if a locale is in the
 `mar_locales` list.
 > >
 > > The update generation is following our bundle generation which is kind
 of split in two parts. The first part is used for `en-US` which is
 shipping no lang packs. The second part is used for all the other locales
 which ship with the respective lang pack.
 >
 > Yes. I'm wondering if we could simplify that and treat `en-US` like the
 other locales, maybe as a separate ticket.

 I think we should fix that by moving to single-locale bundles which we
 want to do anyway for a number of reasons, see: #27466. Then the whole
 treatment of `en-US` vs. the other bundles vanishes for free. I am not
 sure whether it is worth filing a separate bug for the simplification
 part, though.

 [snip]

 > It seems also that we generate mar files for nightly builds even if
 `var/build_mar` is set to `0`. I fixed that in an other fixup commit:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32475_v3&id=4000bbdbd796ffb24766a4f327edc16bbce7aeed

 That's a good catch. However, I feel there is no need to iterate through
 all the locales just to hit the case that .mar files should not be built.
 Can't we get that change by just doing something like
 `IF c("var/nightly") && c("var/build_mar")` once at the beginning?

 [snip]

 > > I find it error-prone as well that we continue to use at one hand `[%
 IF c("var/build_mar") -%]` and at the other hand `[% IF build_mar -%]` for
 deciding whether to create full .mar files or not.
 >
 > Hmm, I'm not sure how to make that less confusing. In the first case
 (for `en-US`) we only need to look at `c("var/build_mar")`. In the second
 case we need to use a local variable as it is more complicate. Would
 renaming the variable to something else than `build_mar` be less
 confusing?

 No, I think we should keep it that way if we need it because otherwise
 folks might just grep for `var/build_mar` while searching for the code
 parts they need to change and thereby missing some. This can already
 happen with your proposed changes if one greps for `[% IF
 c("var/build_mar") -%]` assuming all the update relevant checks are done
 that way. What we could do is setting `build_mar` earlier and then use `[%
 IF build_mar -%]` check everywhere in the `tor-browser` build script. But
 maybe it's enough someone actually working on that part of the code would
 just grep for `build_mar`, dunno. I think I could live with the status
 quo.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32475#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online