[tor-bugs] #32609 [Core Tor/Tor]: Improve practracker unit tests, and run them in "make check" and pre-commit
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Nov 26 01:37:31 UTC 2019
#32609: Improve practracker unit tests, and run them in "make check" and pre-commit
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: test, network-team-roadmap-november | Actual Points: 0.4
Parent ID: #32522 | Points: 0.4
Reviewer: nickm | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Comment (by teor):
This isn't quite the fix I wanted, so I'd like your advice.
I noticed that we merged a commit that included an entire ".c" file in a
unit test, and I'd like "make check" to fail when that happens.
Is there a way we can restrict includes to ".h" and ".inc"?
Perhaps with some custom code in practracker includes.py?
(I fixed the issue in d7fdab49f79c6c1ba3e0c8147ad9242f09d29f2c, but I'm
concerned it got past review.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32609#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list