[tor-bugs] #31992 [Applications/Tor Browser]: Remove apktool workaround in #31564

[Tor Bug Tracker & Wiki]

#31992: Remove apktool workaround in #31564
-------------------------------------------+--------------------------
 Reporter:  gk                             |          Owner:  sisbell
     Type:  defect                         |         Status:  assigned
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID:                                 |         Points:  0.25
 Reviewer:                                 |        Sponsor:
-------------------------------------------+--------------------------

Comment (by eighthave):

 apktool is first and foremost an inspection and reverse engineering tool.
 Using it in production releases will never be well supported.  The marks
 it leaves on the APK make malware scanners consider the APK malware, since
 that's the vast majority of APKs assembled with apktool are malware, at
 least according to the sources I've discusses this with.

 If you're going to make custom build tools, I think it'll be a lot more
 effective to customize the official Android build tools as needed, as
 painful as building them is.  For example, the Debian Android Tools team
 would love to include reproducible patches in the packages, even though
 the Google binaries do not, as long as they don't break compatibility.
 Same with this project: https://android-rebuilds.beuc.net/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31992#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online