[tor-bugs] #32476 [Applications/Tor Browser]: Support Launching TorService Using JNI

[Tor Bug Tracker & Wiki]

#32476: Support Launching TorService Using JNI
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201911                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 I realize its early development. Some review comments.

 1) I still see that we need to wait for the control port creation file.
 This is what was causing some earlier problems. Will this be fixed with
 the JNI code in the future or does the problem lie in the tor code itself?

 2) Authentication appears to just be default, with no cookies. If we add
 cookie base auth, I think we would also need to wait for that file
 creation as well.

 I bring up (1) and (2) specifically since these were pain points in the
 past and don't seem to be mitigated in the current code.

 3) The JNI code will lock down the implementation class as TorService,
 which is also the Android service class. I think it would be better to
 move the JNI interaction to a different class, which is then called by
 TorService class. This will make it more reusable by third-parties.

 4) We are using file descriptor for the control port with the JNI version.
 This is good. (It does mean this only support *nix based systems).

 I agree we should move forward with JNI integration since we shouldn't be
 spawning processes on Android. However, outside of this general principle,
 I don't see any additional JNI advantages at this point.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32476#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online