[tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 25 02:16:22 UTC 2019


#20218: Fix and refactor and redocument routerstatus_has_changed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, 029-proposed, tor-control,     |  Actual Points:  0.5
  easy, spec-conformance, review-group-31,       |
  034-triage-20180328, 034-removed-20180328      |
Parent ID:                                       |         Points:  .1
 Reviewer:  nickm, teor                          |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:  nickm => nickm, teor


Comment:

 Just a few changes needed to the fields, comments, and changes file.

 I also think we need unit tests for:
 * `routerstatus_has_changed()`, and
 * `routerstatus_format_entry(..., NS_CONTROL_PORT, ...)`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20218#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list