[tor-bugs] #32380 [Applications/Tor Browser]: Get current Tor Browser code ready for RLBox

[Tor Bug Tracker & Wiki]

#32380: Get current Tor Browser code ready for RLBox
---------------------------------------------+--------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  defect                           |         Status:  new
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tbb-security, GeorgKoppen201911  |  Actual Points:
Parent ID:  #32379                           |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+--------------------------

Comment (by gk):

 Okay, with `bug_30380_v3` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_32380_v3) I get the following build issue:
 {{{
  1:06.10 /var/tmp/build/firefox-
 301a46905ed1/gfx/thebes/gfxFcPlatformFontList.cpp:495:18: error: value of
 type 'tainted_opaque<gr_face *, RLBoxThebes_T_Sbx>' (aka
 'tainted_opaque<gr_face *, rlbox::rlbox_noop_sandbox>') is not
 contextually convertible to 'bool'
  1:06.10   if (mHBFace || mGrFace) {
  1:06.10                  ^~~~~~~
  1:06.10 /var/tmp/build/firefox-
 301a46905ed1/gfx/thebes/gfxFcPlatformFontList.cpp:495:15: error: invalid
 operands to binary expression ('hb_face_t *' and 'tainted_opaque<gr_face
 *, RLBoxThebes_T_Sbx>' (aka 'tainted_opaque<gr_face *,
 rlbox::rlbox_noop_sandbox>'))
  1:06.10   if (mHBFace || mGrFace) {
  1:06.10       ~~~~~~~ ^  ~~~~~~~
  1:06.10 /var/tmp/build/firefox-301a46905ed1/obj-x86_64-pc-linux-
 gnu/dist/include/mozilla/rlbox/rlbox.hpp:793:1: note: candidate template
 ignored: could not match 'tainted_base_impl' against 'tainted_opaque'
  1:06.11 BooleanBinaryOpWrappedRhs(||);
  1:06.11 ^
  1:06.11 /var/tmp/build/firefox-301a46905ed1/obj-x86_64-pc-linux-
 gnu/dist/include/mozilla/rlbox/rlbox.hpp:747:25: note: expanded from macro
 'BooleanBinaryOpWrappedRhs'
  1:06.11   inline constexpr auto operator opSymbol(
 \
  1:06.11                         ^
  1:06.11 /var/tmp/build/firefox-301a46905ed1/obj-x86_64-pc-linux-
 gnu/dist/include/mozilla/rlbox/rlbox.hpp:793:1: note: candidate template
 ignored: could not match 'tainted_base_impl' against 'tainted_opaque'
  1:06.11 /var/tmp/build/firefox-301a46905ed1/obj-x86_64-pc-linux-
 gnu/dist/include/mozilla/rlbox/rlbox.hpp:765:25: note: expanded from macro
 'BooleanBinaryOpWrappedRhs'
  1:06.11   inline constexpr auto operator opSymbol(
 \
  1:06.11                         ^
  1:06.86 2 errors generated.
  1:06.88 make[1]: *** [gfxFcPlatformFontList.o] Error 1
 }}}
 Our toolchain is fine in that it can compile the respective code from the
 canonical
 [https://treeherder.mozilla.org/#/jobs?repo=try&revision=f315fe26d1731d325eb8981a5bfe7e7c819842fd
 try push]. It seems we have the problem that the patch for
 https://bugzilla.mozilla.org/show_bug.cgi?id=1547063 did not land on ESR
 68.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32380#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online