[tor-bugs] #32427 [Core Tor/Tor]: Refactor options_act_reversible into manageable chunks

[Tor Bug Tracker & Wiki]

#32427: Refactor options_act_reversible into manageable chunks
-------------------------------------------+-------------------------------
 Reporter:  nickm                          |          Owner:  nickm
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.3.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  .3
Parent ID:  #32408                         |         Points:
 Reviewer:  teor                           |        Sponsor:  Sponsor31-can
-------------------------------------------+-------------------------------

Comment (by nickm):

 Okay, this is looking better. Tests are passing, chutney is passing, test-
 stem is passing.

 I've added a bunch of comments to explain the ordering in
 options_act_reversible.  I think that the actual correct division of
 responsibility is something like:

   * Pre-configuration
   * Post-configuration, pre-fork.
   * Post-fork, pre-setuid.
   * post-setuid.

 Having the torrc, having daemonized and having setuid are the important
 barriers here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32427#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online