[tor-bugs] #32427 [Core Tor/Tor]: Refactor options_act_reversible into manageable chunks

[Tor Bug Tracker & Wiki]

#32427: Refactor options_act_reversible into manageable chunks
-------------------------------------------+-------------------------------
 Reporter:  nickm                          |          Owner:  nickm
     Type:  enhancement                    |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.3.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  .3
Parent ID:  #32408                         |         Points:
 Reviewer:  teor                           |        Sponsor:  Sponsor31-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * keywords:   => network-team-roadmap-november


Comment:

 Looks good!

 I left a documentation question on the pull request.

 I think the listening tests are fine, it's totally understandable that we
 can't test everything yet. We can do more refactoring and tests in future.

 This branch seems to have stopped logging:
 {{{
 Your log may contain sensitive information
 }}}
 That seems like a log we might actually want to keep?

 There's only one test that fails, and it's the "large" one.
 Here's the full diagnostic output:
 {{{
 large_1: FAIL: Expected log success './expected_log':
 Your log may contain sensitive information
 Tor --verify-config said:
 $ /Users/travis/build/torproject/tor/src/app/tor --verify-config -f
 ./torrc --defaults-torrc
 /var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/tor_parseconf_tests.XXXXXX.vkKDe7kz/EMPTY
 Nov 19 22:16:24.511 [notice] Tor 0.4.3.0-alpha-dev (git-f5a08f6966d72594)
 running on Darwin with Libevent 2.1.11-stable, OpenSSL 1.0.2t, Zlib
 1.2.11, Liblzma 5.2.4, and Libzstd 1.4.3.
 Nov 19 22:16:24.513 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Nov 19 22:16:24.513 [notice] This version is not a stable Tor release.
 Expect more bugs than usual.
 Nov 19 22:16:24.513 [notice] Read configuration file
 "/var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/tor_parseconf_tests.XXXXXX.vkKDe7kz/EMPTY".
 Nov 19 22:16:24.513 [notice] Read configuration file
 "/Users/travis/build/torproject/tor/src/test/conf_examples/large_1/./torrc".
 Nov 19 22:16:24.517 [warn] The ClientPreferIPv6DirPort option is
 deprecated, and will most likely be removed in a future version of Tor. It
 has no effect on relays, and has had no effect on clients since 0.2.8. (If
 you think this is a mistake, please let us know!)
 Nov 19 22:16:24.518 [warn] The ReachableDirAddresses option is deprecated,
 and will most likely be removed in a future version of Tor. It has no
 effect on relays, and has had no effect on clients since 0.2.8. (If you
 think this is a mistake, please let us know!)
 Nov 19 22:16:24.520 [warn] You have asked to exclude certain relays from
 all positions in your circuits. Expect hidden services and other Tor
 features to be broken in unpredictable ways.
 Nov 19 22:16:24.524 [notice] Not disabling debugger attaching for
 unprivileged users.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32427#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online