[tor-bugs] #5915 [Core Tor/Tor]: Write patch to make socks handshakes succeed instantly

[Tor Bug Tracker & Wiki]

#5915: Write patch to make socks handshakes succeed instantly
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  needs-proposal, tor-client, intro,   |  Actual Points:
  performance, application, experiment, tbb-     |
  wants?, performance?, ux,                      |
  042-deferred-20190918                          |
Parent ID:                                       |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 the patch works since patched against tor stable for testing this poc.
 only negative thing noticed so far, is the following line:


 {{{
 [warn] {BUG} connection_ap_handshake_socks_reply(): Bug: (Harmless.)
 duplicate calls to connection_ap_handshake_socks_reply. (on Tor 0.4.1.6 )
 }}}
 i believe its a race condition from SOCKS_COMMAND_IS_CONNECT
 but without log lines wouldn't noticed this either

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5915#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online