[tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

[Tor Bug Tracker & Wiki]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201911R =>
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 JeremyRand]:
 > > Thanks for the patches! The construction with the ncdns-repro repo
 seems weird. I don't think this belongs into the top level of the tor-
 browser-build repo. Rather, looking at its contents this needs to get
 integrated into the projects. Or, rather, all the projects you need should
 get integrated into projects. But maybe I am missing something here. Could
 you elaborate?
 >
 > My reasoning was that Namecoin already maintains rbm projects for most
 of the binaries we distribute, so it would reduce maintenance effort to
 simply reuse Namecoin's rbm projects folder (via a Git submodule) rather
 than require the Tor Browser devs to regularly copy Namecoin's projects
 folder into Tor Browser's projects folder.  But, if you prefer to have Tor
 Browser keep its own copy of Namecoin's projects rather than reuse
 Namecoin's version as a Git submodule, that's fine with me and I can make
 that change.  Let me know what you'd prefer.

 Hrm. I am not convinced yet that the maintenance effort is (so much)
 higher given that we want to review any changes anyway before applying
 them tor `tor-browser-build` and we might even want to cherry-pick some
 changes and not other which I think could be harder in the submodule
 setup. Thus, let's try it the way I proposed above and see it as part of
 the experiment we are doing.

 I was not aware that Namecoin is using `rbm` as well, which is very nice!
 Keep it going. :)

 > > FWIW: there is at least one (non-fatal) error I get during running the
 build that might be related to the above as you seem to try to remove a
 thing that cannot be removed:
 >
 > Indeed, that error gets displayed the first time that the submodule is
 being set up.  The error is harmless, but I can fix that pretty easily
 (though I'll wait for an answer to the above question so that I know
 whether the submodule is staying at all).

 Thanks, yes, fixing this would be good I think.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online