[tor-bugs] #31028 [Circumvention/Snowflake]: Migrate away from the custom websocket library

[Tor Bug Tracker & Wiki]

#31028: Migrate away from the custom websocket library
-------------------------------------+-------------------------
 Reporter:  arlolra                  |          Owner:  arlolra
     Type:  defect                   |         Status:  closed
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:  fixed
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-------------------------
Changes (by arlolra):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:7 dcf]:
 > I had a look at this and my observations are the same as cohosh's in
 comment:5. Sending a CloseMessage before closing seems prudent as that's
 what the old code did.

 Right, sorry for the omission.  I merged a patch for that in,
 https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=abefae158716b9f56692ea16336c1f8185eda27e

 and the bulk of this in,
 https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=c417fd5599c5d39951c606856c69a9f05941afd3


 > > Should we move to the Gorilla websocket library for the proxy-go
 instances as well?
 >
 > Sure, IMO it's not as important because proxy-go only connects to a
 known server (not receiving connections from anywhere as the server does),
 and only needs to be compatible with the server's WebSocket implementation
 (unlike the server which has to be compatible with many browsers). It's a
 good idea anyway. I'd say let's get this ticket closed out first.

 I opened #32465 for that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31028#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online