[tor-bugs] #32427 [Core Tor/Tor]: Refactor options_act_reversible into manageable chunks
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Nov 11 21:58:38 UTC 2019
#32427: Refactor options_act_reversible into manageable chunks
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points: .3
Parent ID: #32408 | Points:
Reviewer: teor | Sponsor: Sponsor31-can
--------------------------+------------------------------------
Comment (by nickm):
Those renamings sound reasonable. I hope that in the long run they'll be
irrelavant as this function becomes subsystem-driven (see parent), but for
now they seem okay to me.
I've made the easier changes on the ticket, and added a
ControlSocketsGroupWritable test. Here's my current plan:
1. add tests for creating directories
2. try unit tests for logs and sockets, assuming I can do that in no more
than a couple of hours each.
3. rename the functions.
4. Back in needs review.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32427#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list