[tor-bugs] #32408 [Core Tor/Tor]: Handle options_act_reversible() in new config system.

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Nov 11 04:44:16 UTC 2019


#32408: Handle options_act_reversible() in new config system.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #29211        |         Points:  1.5
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by teor):

 The design looks good.

 How about naming things by what they *are*:
 * options_act_pre_port()
 * options_act_port()
 * options_act_pre_log()
 * options_act_log()
 * options_act...()

 And then if someone wants to know the order, they can read the comments or
 the code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32408#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list