[tor-bugs] #32447 [Core Tor/Tor]: Refactor our initialization sequence into a logical order

[Tor Bug Tracker & Wiki]

#32447: Refactor our initialization sequence into a logical order
-------------------------------+--------------------------------
     Reporter:  nickm          |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:
Actual Points:                 |  Parent ID:
       Points:  .5             |   Reviewer:
      Sponsor:  Sponsor31-can  |
-------------------------------+--------------------------------
 There are several things I'd like out of a logical initialization
 sequence.

 1. I'd like nt_service_parse_options() to happen at immediately before our
 first call to config_parse_commandline().

 2. I'd like us to divide our initialization stages into separate function
 calls, divided based on how much of the commandline or config we have
 parsed up until then.  The main "inflection points" in this process are
 calls to nt_service_parse_options(), config_parse_commandline(), and
 options_init_from_torrc().

 3. I'd like us to turn as much of our initialization into subsystems as
 possible.

 Unfortunately, we do not have good unit tests for our NT services code,
 which makes reordering that troublesome.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32447>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online