[tor-bugs] #30867 [Circumvention/Snowflake]: Write proxy-go tests to cover existing implementation

[Tor Bug Tracker & Wiki]

#30867: Write proxy-go tests to cover existing implementation
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  cohosh
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tests, anti-censorship-roadmap-      |  Actual Points:  2
  september                                      |
Parent ID:  #29259                               |         Points:  2
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor28
-------------------------------------------------+-------------------------
Changes (by dcf):

 * status:  needs_review => merge_ready


Comment:

 Looks good, thanks. I would suggest moving `SDP`, `sampleSDP`,
 `sampleOffer`, and `sampleAnswer` inside `TestBrokerInteractions` where
 they are used.

 Incidentally, the new tests reveal that some functions are probably
 logging at too low a level -- I normally wouldn't expect the kind of code
 dealt with in unit tests to log.
 {{{
 2019/11/09 13:53:45 invalid character 'e' in literal true (expecting 'r')
 .2019/11/09 13:53:45 Cannot deserialize SessionDescription without sdp
 field.
 .2019/11/09 13:53:45 Cannot deserialize SessionDescription without type
 field.
 .2019/11/09 13:53:45 Unknown SDP type

 ...2019/11/09 13:53:45 io.Copy inside CopyLoop generated an error: io:
 read/write on closed pipe
 2019/11/09 13:53:45 io.Copy inside CopyLoop generated an error: io:
 read/write on closed pipe
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30867#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online