[tor-bugs] #31028 [Circumvention/Snowflake]: Migrate away from the custom websocket library

[Tor Bug Tracker & Wiki]

#31028: Migrate away from the custom websocket library
-------------------------------------+-----------------------------
 Reporter:  arlolra                  |          Owner:  arlolra
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-----------------------------
Changes (by dcf):

 * status:  needs_information => merge_ready


Comment:

 I had a look at this and my observations are the same as cohosh's in
 comment:5. Sending a CloseMessage before closing seems prudent as that's
 what the old code did.

 > Should we move to the Gorilla websocket library for the proxy-go
 instances as well?

 Sure, IMO it's not as important because proxy-go only connects to a known
 server (not receiving connections from anywhere as the server does), and
 only needs to be compatible with the server's WebSocket implementation
 (unlike the server which has to be compatible with many browsers). It's a
 good idea anyway. I'd say let's get this ticket closed out first.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31028#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online