[tor-bugs] #32365 [Applications/Tor Browser]: Localization is broken in Tor Browser 9 on Android

[Tor Bug Tracker & Wiki]

#32365: Localization is broken in Tor Browser 9 on Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0-regression,  |  Actual Points:
  TorBrowserTeam201911                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * status:  new => needs_review


Comment:

 Replying to [comment:4 gk]:
 > Replying to [comment:2 sysrqb]:
 > > Replying to [comment:1 gk]:
 > > > I wonder whether this issue is actually related to #28196, but maybe
 not.
 > > It seems all chrome content is correctly localized, but the Java
 strings are not localized. Hopefully there is a simple fix.
 >
 > Not sure if you are seeing the same bug as I but for me essentially the
 whole browser chrome is *not* localized. The exception here is UI coming
 from Torbutton which *is* localized. So, e.g. the whole Settings menu
 items are only in English.
 Right, sorry, "chrome" wasn't the correct description. I should've said
 something like "privileged-chrome content". For example, `about:firefox`
 is correctly localized, but I see the menu and and preferences are not
 localized.

 It seems the reason for this is Mozilla changed how they create multi-
 locale packages. We have two options.

 1) I have a patch for this in my tor-browser-build repo,
 `bug32365_00`.Unfortunately, the firefox build is broken using this method
 because apparently we broke `./mach android archive-geckoview`, and this
 is called as the final step in `./mach package-multi-locale`. I created a
 tor-browser patch that comments-out calling `./mach android archive-
 geckoview`, as a workaround.

 2) Another alternative is we re-implement `./mach package-multi-locale` in
 the firefox build file. It is relatively straight-forward, see
 `package_l10n` in `python/mozbuild/mozbuild/mach_commands.py`. I have
 another branch with only this tor-browser-build patch, `bug32365_01`.

 Considering option (2) is a small change, that seems like the better
 solution. I'm building a small variant of (2) now, as well - using `./mach
 package` instead of `make package`. It's possible `./mach android
 assemble-app` is the only missing piece.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32365#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online