[tor-bugs] #32410 [Core Tor/Tor]: --disable-module-relay causes us to reject default options

[Tor Bug Tracker & Wiki]

#32410: --disable-module-relay causes us to reject default options
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  teor
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.2
Parent ID:                |         Points:  0.1
 Reviewer:  nickm         |        Sponsor:  Sponsor31-must
--------------------------+------------------------------------
Changes (by teor):

 * actualpoints:  0.1 => 0.2


Comment:

 A bunch of the relay parsing tests acted differently after this change, I
 think it's an improvement.

 Except that tor-no-relay sets ClientOnly in all torrcs. So I changed the
 ClientOnly default to 1, just like I changed the DirCache default to 0.

 I made that fix, updated the tests, and force-pushed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32410#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online