[tor-bugs] #32385 [Core Tor/Tor]: doxygen: respect --enable-fatal-warnings

[Tor Bug Tracker & Wiki]

#32385: doxygen: respect --enable-fatal-warnings
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  doxygen       |  Actual Points:
Parent ID:                |         Points:  0
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Thanks! This mostly looks good. I left a minor suggestion on the pull
 request.

 Also, I noticed the following Doxygen error when manually running `make
 doxygen`:
 {{{
 /Users/tlyu/src/tor/src/core/or/core_or.dox:63: error: Reached end of file
 while still inside a (nested) comment. Nesting level 1 (probable line
 reference: 1) (warning treated as error, aborting now)
 }}}
 which looks like it was introduced by
 e1cdca2e4f58c108539fe4c36205b16caca8d44f. I'm not sure whether we should
 fix it as part of this ticket or open a new one. I think it's not the only
 warning, though, because at least one more pops up if I fix core_or.dox.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32385#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online