[tor-bugs] #30866 [Core Tor/Tor]: Teach config.c to work with options configured in other modules

[Tor Bug Tracker & Wiki]

#30866: Teach config.c to work with options configured in other modules
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #29211        |         Points:  2
 Reviewer:  teor          |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 Okay, I've done some more work here to make it better.  I've done #32406
 so that we can mark an accelerator as required, which lets us test
 failures in options_set().

 And wouldn't you know it, there was a bug in options_set()!  If
 options_act() failed while we did not have an event loop initialized, we
 would crash in tor_shutdown_event_loop_and_exit(). That's #32407: I've
 done a separate branch for that against 0.3.5.

 I've squashed the fixups on the branch, rebased it on master, and added
 the #32407 fix.  The new branch is `config_subsys_v3`. Its PR is
 https://github.com/torproject/tor/pull/1514.

 I'm going to wait for CI to pass here, at least.  I think that #32406 and
 #32407 are enough of a change that I should wait for review on them before
 I merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30866#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online