[tor-bugs] #32399 [Core Tor/Tor]: Fix "make test-stem" after merging #32339 and #32344

[Tor Bug Tracker & Wiki]

#32399: Fix "make test-stem" after merging #32339 and #32344
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  nickm
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  043-regression, network-team-
     Severity:  Normal   |  roadmap-november
Actual Points:           |  Parent ID:  #29211
       Points:           |   Reviewer:
      Sponsor:           |
  Sponsor31-must         |
-------------------------+-------------------------------------------------
 In #32339 and #32344, we broke "make test-stem", but we didn't notice
 before merging, because "make test-stem" is allow_failure in Travis CI.

 It looks like we need to get stem to launch a new tor process for more
 tests. Or our immutability checks are too strict.

 Here is one of the errors:
 {{{
 ======================================================================
 FAIL: test_take_ownership_via_controller
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File "/home/dev/stem/stem/util/test_tools.py", line 152, in <lambda>
     self.method = lambda test: self.result(test)  # method that can be
 mixed into TestCases
   File "/home/dev/stem/stem/util/test_tools.py", line 227, in result
     test.fail(self._result.msg)
 AssertionError: Traceback (most recent call last):
   File "/home/dev/stem/stem/util/test_tools.py", line 169, in _wrapper
     runner(*args) if args else runner()
   File "/home/dev/stem/test/integ/process.py", line 641, in
 test_take_ownership_via_controller
     take_ownership = True,
   File "/home/dev/stem/stem/process.py", line 285, in
 launch_tor_with_config
     return launch_tor(tor_cmd, ['-f', '-'], None, completion_percent,
 init_msg_handler, timeout, take_ownership, close_output, stdin =
 config_str)
   File "/home/dev/stem/stem/process.py", line 158, in launch_tor
     raise OSError('Process terminated: %s' % last_problem)
 OSError: Process terminated: Failed to bind one of the listener ports.


 ----------------------------------------------------------------------
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32399>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online