[tor-bugs] #32220 [Applications/Tor Browser]: Change letterboxing color when dark theme is enabled

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Nov 5 01:21:54 UTC 2019


#32220: Change letterboxing color when dark theme is enabled
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-   |  Actual Points:  5
  team, TorBrowserTeam201911R                    |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by pospeselr):

 * status:  needs_revision => needs_review
 * keywords:  tbb-9.0-issues, tbb-9.0.1-can, ux-team, TorBrowserTeam201911
     => tbb-9.0-issues, tbb-9.0.1-can, ux-team, TorBrowserTeam201911R
 * actualpoints:   => 5


Comment:

 **gk**: Letterboxing now only occurs when necessary and there are no more
 unconditional CSS changes (each rule is now behind a 'letterbox' class). I
 haven't seen the scrollbar color issue you've described with the most
 recent patch.

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_32220_v2

 The browser content is now anchored to the toolbar, but the toolbar's
 horizontal border must remain. If we end up not liking that horizontal
 line, we can go further in and modify the global styles a bit.

 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/abouttor%20letterboxed.png, 700)]]

 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/32220/abouttor%20none.png, 700)]]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32220#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list