[tor-bugs] #27268 [Applications/Tor Browser]: preferences cleanup

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Nov 1 20:29:16 UTC 2019


#27268: preferences cleanup
-------------------------------------------------+-------------------------
 Reporter:  rzb                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, TorBrowserTeam201911,      |  Actual Points:
  GeorgKoppen201911                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => new
 * keywords:  ff68-esr, TorBrowserTeam201910R, GeorgKoppen201910 =>
     ff68-esr, TorBrowserTeam201911, GeorgKoppen201911


Comment:

 Replying to [comment:25 mcs]:
 > Replying to [comment:20 gk]:
 > > `bug_27268` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=bug_27268) has the first batch of prefs fixups for
 review (two commits). There is a Torbutton patch, too, in `bug_27268`
 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27268&id=a2eac79bab7c2afa17cd45109a5669cf528215c0):
 Note, I removed `security.pki.sha1_enforcement_level` as well even though
 the pref is still in action. But we set it to a lower value than Mozilla
 ships today which we should not do.
 >
 > r=mcs
 > These patches look good to me, although I did not re-do all of the deep
 detective work that other people have already done for this ticket. I
 tried to do a sanity check for each removed pref though.
 >
 > > We should figure out as well whether there is a new hotfix mechanism
 that still needs to get disabled.
 >
 > Do we need a new ticket for that task?

 Could be. I need to look closer and will pick this whole ticket up in
 November again. So setting this to `new` and amending the keywords to not
 lose track here.

 I've picked the Torbutton commit and applied it to `master` (commit
 73a43f2f4d846b2870757d7aa18a1b33643ba2b5) and `maint-9.0` (commit
 09e3050265303eff776ba540861c533d5cab2254).

 The browser related commits landed on `tor-browser-68.2.0esr-9.0-1`
 (commits 5e83d0a74e4d5ccaef5275e3cc0bfe36e77e9315 and
 479630e18d3c184846f94e2e1e53f6d4df1c5cb) and `tor-browser-68.2.0esr-9.5-1`
 (commits b9e148eb996515e18ce47cd42f18b6dd967c1cbd and
 1762a2a4ba9eb9eca76f9d522f456dd262a99f84).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27268#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list