[tor-bugs] #30676 [Core Tor/Tor]: From test-stem coverage, infer which events and commands are not getting covered

[Tor Bug Tracker & Wiki]

#30676: From test-stem coverage, infer which events and commands are not getting
covered
--------------------------+----------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  041-should    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by atagar):

 Hi Nick. I'd be delighted to add coverage for those commands if you have
 test scenarios you'd care to propose.

 That said, in most of their cases (ATTACHSTREAM, HSFETCH, etc) the command
 requires a live network connection, which are not ran by default due to
 their long runtime and potential for false positives. In fact, in some of
 these cases Stem *does* have coverage, it's not getting invoked because
 Travis doesn't include the '--target ONLINE' argument. For example, here's
 our HSFETCH test...

 https://gitweb.torproject.org/stem.git/tree/test/integ/control/controller.py#n1282

 Teor is helping me migrate to Travis (#30653) and I requested for us to
 run online tests as part of Stme's CI. If tor would like to run online
 stem's online tests as well that will increase coverage, but come at the
 cost of runtime and added chance of false positives.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30676#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online