[tor-bugs] #28170 [Core Tor/Stem]: Test stem pull requests against all supported tor versions, and tor nightly builds

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon May 27 02:02:50 UTC 2019


#28170: Test stem pull requests against all supported tor versions, and tor nightly
builds
---------------------------+-------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  enhancement    |         Status:  needs_review
 Priority:  Medium         |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  ci, travis     |  Actual Points:  0.2
Parent ID:  #29729         |         Points:  0.2
 Reviewer:                 |        Sponsor:  Sponsor31-can
---------------------------+-------------------------------

Comment (by teor):

 Replying to [comment:11 atagar]:
 > Before resolving this I'd like to check - does it make sense for the
 travis config to live in this repository? I use
 [https://jenkins.torproject.org/job/stem-tor-ci/ Jenkins] for my CI. I
 don't use this configuration, and as such don't have an opinion about
 what's in it or know if it breaks.
 >
 > I'd be happy to merge changes if you'd like to keep it here, but I'm
 unsure if there's value in requiring me to be in the loop on its
 maintenance.

 If the Travis CI config is in the Stem repository, then anyone can run
 Travis CI on their Stem pull requests. That's the standard config for CIs
 like Travis and Appveyor.

 Using git for the CI config also allows different CI config for different
 release branches. That isn't as important for Stem, because your backports
 are usually pretty small.

 Replying to [comment:12 atagar]:
 > Oh! And to be clear, if you'd care to suggest that I use Travis rather
 than Jenkins for my CI I'd be open to discussing that too. Personally I
 don't have any strong opinions at the moment about what kind of CI Stem
 uses for itself.

 The network team uses Travis and Appveyor to check our Tor branches. Our
 Travis and Appveyor tests are more comprehensive, because they run
 different build options, Windows, Stem, and soon Chutney. Travis and
 Jenkins also let us run CI on our branches before we merge them.

 We use Jenkins to test rarer architectures, and build binary packages.

 Tor's CI runs a Stem job. To avoid breaking Tor's CI, we need all of
 Stem's changes to pass Stem's CI. (And we need Stem's CI tests to be
 roughly equivalent to Tor's CI tests.) So we would really like to have
 Stem's Travis and Jenkins CIs pass all the time.

 I don't know if you want to check both Travis and Jenkins after you merge,
 or if you want to standardise on one of them. (Checking multiple CI
 platforms adds more work.)  But we'll check Stem's CI when Tor's Stem job
 fails, so we can work out if it was Tor or Stem that broke first.

 We can also use Stem's Travis CI to check our Stem branches, but we don't
 write very many of them.

 So it's totally up to you.

 Let's try it for a while and see how it goes?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28170#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list