[tor-bugs] #30455 [Core Tor/Tor]: Improve documentation for chutney warnings in "make test-network-all" (was: Does "make test-network-all" test every network twice?)

[Tor Bug Tracker & Wiki]

#30455: Improve documentation for chutney warnings in "make test-network-all"
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  chutney, easy, doc, tor-ci,          |  Actual Points:
  041-should                                     |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  035-backport?, 040-backport?, chutney, easy, tor-ci,
     041-should => chutney, easy, doc, tor-ci, 041-should
 * points:   => 0.1
 * type:  defect => enhancement


Comment:

 Replying to [comment:4 nickm]:
 > Findings so far:
 >   * This bug was new in 0.3.0.4.
 >   * We are indeed trying to run everything twice.
 >   * We are not actually running everything twice, since
 TEST_NETWORK_WARNING_FLAGS seems to be broken: it uses `--only-warnings`,
 which appears to prevent the test from running entirely.

 This is not a bug.

 The extra line logs chutney warnings to the terminal. Before this change,
 tor's warnings were only logged to a file. And if chutney succeeded, no-
 one would read that file. So we would miss any warnings that tor had
 logged.

 For more details, see #21570 or the changes file in commit
 fb32c522320430f.

 > Any other fixes here should probably come after we merge our other "use
 chutney for CI" tickets, since they are likely to touch this part of the
 makefile as well.

 We could change the variable name so it is move obvious:
 TEST_NETWORK_SHOW_LAST_WARNINGS_FLAGS
 And we could add a comment above the makefile block.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30455#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online