[tor-bugs] #30615 [Core Tor/Tor]: Factor random_uniform_01 into nondeterministic and deterministic parts, and automatically test the deterministic part

[Tor Bug Tracker & Wiki]

#30615: Factor random_uniform_01 into nondeterministic and deterministic parts, and
automatically test the deterministic part
--------------------------------+------------------------------
 Reporter:  riastradh           |          Owner:  (none)
     Type:  enhancement         |         Status:  new
 Priority:  Low                 |      Component:  Core Tor/Tor
  Version:  Tor: 0.4.1.1-alpha  |       Severity:  Minor
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
 The `random_uniform_01` code is not automatically tested by any
 ''deterministic'' tests -- it is tested only by the ''stochastic'' tests
 in the slow test suite.  However, there is a not-entirely-trivial
 deterministic computation inside it, wired up to a (truncated)
 geometric(1/2) sampler and a uniform bit sampler.  And it turns out that
 this deterministic computation ''technically'' has a bug, although the bug
 triggers with probability <2^-900^ so it doesn't really matter.  But it is
 nice to have deterministic tests for correct behaviour of the
 deterministic part of a random sampler, and nice for that deterministic
 part to not have bugs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30615>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online