[tor-bugs] #30150 [Core Tor/Tor]: Fix coverity warnings in tests

[Tor Bug Tracker & Wiki]

#30150: Fix coverity warnings in tests
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  041-should    |  Actual Points:  .1
Parent ID:  #30146        |         Points:
 Reviewer:  dgoulet       |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 This seems to mostly fix this pattern:

 {{{
 +  if (service) {
 +    remove_service(get_hs_service_map(), service);
 +    hs_service_free(service);
 +  }
    hs_free_all
 }}}

 But `hs_free_all` goes over the service map and frees every entry so it is
 really not necessary to do so. The `helper_create_service()` in the HS
 tests always register the service to the global map.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30150#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online