[tor-bugs] #29528 [Core Tor/Tor]: UndefinedBehaviorSanitizer errors should fail the unit tests

[Tor Bug Tracker & Wiki]

#29528: UndefinedBehaviorSanitizer errors should fail the unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-test, 041-proposed,      |  Actual Points:  0.2
  029-backport, 034-backport, 035-backport,      |
  040-backport, 041-should                       |
Parent ID:                                       |         Points:  2
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:21 cypherpunks]:
 > Replying to [comment:19 teor]:
 > > When we pass -fsanitize=undefined -fno-sanitize-recover=undefined
 -fsanitize-trap=undefined  -fsanitize-undefined-trap-on-error:
 > `trap` ones override non-trap ones and don’t use buggy UBSan run-time
 support.

 So the UBSan runtime reports divisions by zero, but the UBSan trap does
 not?
 That's also really weird. And makes it hard to work out which one we
 should use.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29528#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online