[tor-bugs] #30512 [Circumvention/Snowflake]: Enable cache for ACME certificates in broker

[Tor Bug Tracker & Wiki]

#30512: Enable cache for ACME certificates in broker
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  (none)
     Type:  enhancement              |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  arlolra cohosh dcf phw   |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------

Comment (by phw):

 Replying to [comment:5 dcf]:
 > Replying to [comment:3 phw]:
 > > Yes, good point. I amended my patch:
 https://github.com/NullHypothesis/snowflake/commit/0744b2930e88daf02b039e636e989d60c2467913
 >
 > I'm fine with the general approach. I was wondering if
 `autocert.DirCache` would log itself in that situation or something, but
 it looks like it doesn't provide any function like that.
 >
 > I think
 [https://github.com/NullHypothesis/snowflake/commit/0744b2930e88daf02b039e636e989d60c2467913
 #diff-79897051d7aac1f314600a930afebe9aR227 createCertCacheDir] doesn't
 need to distinguish between the directory already existing and being newly
 created. It only needs to report an error if any.
 >
 > I would prefer if the logging happened at the top level. Have
 `createCertCacheDir` only return an error and not log, and log the error
 message in `main`.

 I incorporated your suggestions and amended the patch:
 https://github.com/NullHypothesis/snowflake/commit/d647285ed4c5dc8567e2a258bfd094c4b572d081

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30512#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online