[tor-bugs] #28780 [Core Tor/Tor]: circpadding: Add machine flag for not closing circuit if machine is active

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 15 06:11:28 UTC 2019


#28780: circpadding: Add machine flag for not closing circuit if machine is active
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:  6
  padding, 041-proposed, network-team-           |
  roadmap-2019-Q1Q2                              |
Parent ID:  #28634                               |         Points:  5
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Thanks Nick! I replied with the specific fixup commit hashes on your
 review in the old PR, but I had to open a new PR due to merge/practracker
 conflicts: https://github.com/torproject/tor/pull/1023

 (I think we should make a new ticket for figuring out a good pattern to
 refactor circuit build timeout, circuit idle expiry, circuit dirty expiry,
 normal circuit close, cannibalization, purpose/ownership changes, and
 error-driven close into a new module/design pattern, and then that one
 could support some kind of API for stuff like this, but I still think this
 approach is pretty narrow and controlled given all of the other snakes in
 this pile).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28780#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list