[tor-bugs] #30489 [Applications/Tor Browser]: Remove Unused Resources from tor-android-service

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 14 18:47:11 UTC 2019


#30489: Remove Unused Resources from tor-android-service
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tor-android-service,     |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:4 gk]:


 > It seems the added strings have some indentation issues like:
 > {{{
 > -  <string name="vpn_default_world">Dünya</string>
 > +    <string name="vpn_default_world">Dünya</string>
 > }}}
 > Could you please fix that? And out of curiosity, how did you determine
 all those strings are not needed anymore? Just grepping?

 There is a refactor code option for cleaning up resources in Android
 Studio. I just run that and then do inspections and searches to make sure
 its doing what I was expecting.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30489#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list