[tor-bugs] #30166 [Applications/Tor Browser]: If custom bridges are specified, only use those bridges for connecting

[Tor Bug Tracker & Wiki]

#30166: If custom bridges are specified, only use those bridges for connecting
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-8.5-must,            |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:17 gk]:
 > I tested a resulting build using `sisbell/0506` + pointing `tor-android-
 service` tor your `0512` and this solves this bug, great! The changes in
 commit 5df4fd213ceda8320fc9e46b12d3bec3024e5c64 seem reasonable to me. A
 small nit: s/confusion../confusion./
 >
 > It seems to me we should open a follow-up ticket cleaning up the
 overloading of the bridges list. That's pretty confusing and makes it hard
 to follow the code. We should come up with a simpler way of
 setting/getting bridges in that regard.
 Not overloading the preference is preferable. I think this change may have
 UI impact, since the UI field we are reading from is also overloaded. This
 will require some looking into to see if this is the case.

 >
 > Setting into `needs_revision` for the nit and for redoing the `tor-
 browser-build` patches taking other review comments into account (http://
 -> https://).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30166#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online