[tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity,            |  Actual Points:
  TorBrowserTeam201905, GeorgKoppen201905        |
Parent ID:  #24855                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):

 * status:  new => needs_revision


Comment:

 I made a draft proposal here:
 https://storm.torproject.org/shared/epDa1tjvv4tocwoK_PW_YijaZm5gbYeKjcriE28jSvY.
 I tried not to do too many changes for the migration and left refactoring
 work for torbutton.js and other chrome/content scripts out of the
 proposal. If you think this is needed, I guess the proposal could be
 extended to include those too.

 I have tested the approach by partially integrating torbutton into firefox
 central according to the document. Working:

 * Circuit display and circuit isolation.
 * New identity/new circuit in burger menu (new identity with some
 suspicious error messages on "restart").
 * NoScript integration for security levels.
 * about:tor

 Still some things missing, like `About Tor Browser` dialog, `torbutton-
 extensions.xul` and others. Can finish it if the proposal is ok.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online