[tor-bugs] #28849 [Core Tor/Tor]: Handle dormant mode in process library and for PT's

[Tor Bug Tracker & Wiki]

#28849: Handle dormant mode in process library and for PT's
--------------------------+----------------------------------
 Reporter:  ahf           |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:  041-proposed  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor19
--------------------------+----------------------------------

Comment (by ahf):

 Thanks a lot for this feedback. I've updated the document now. See
 https://github.com/ahf/torspec/compare/feature/dormant for changes.

 - I have entirely reworded the negotiation process to make use of
 environment variables like the rest of the startup configuration. We now
 use the "TOR_PT_FEATURES" environment variable for the parent process to
 let the PT proxy know of its supported feature extensions. The PT proxy
 can announce its own set of supported feature extensions using the
 "FEATURES" message. I think that addresses all of your concerns in the
 first 6 bullets.
 - I have reworded the dormant messages to be on the form "DORMANT ENTER"
 and "DORMANT EXIT" and the PT proxy response is now made to match the
 request from the parent process.

 I might have missed some details here, please let me know if you spot
 anything and thanks for the review! :-)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28849#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online