[tor-bugs] #29734 [Circumvention/Snowflake]: Broker should receive country stats information from Proxy and Client

[Tor Bug Tracker & Wiki]

#29734: Broker should receive country stats information from Proxy and Client
-------------------------------------+-----------------------------
 Reporter:  cohosh                   |          Owner:  cohosh
     Type:  enhancement              |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  snowflake, geoip, stats  |  Actual Points:  2
Parent ID:  #29207                   |         Points:  1
 Reviewer:  ahf                      |        Sponsor:  Sponsor19
-------------------------------------+-----------------------------

Comment (by cohosh):

 Replying to [comment:30 dcf]:
 > While you are waiting for feedback on #21315, I think it would be okay
 to do a provisional deployment of (say) 7 days in order to get an idea of
 what a typical metrics.log file looks like. In our
 [http://meetbot.debian.net/tor-meeting/2019/tor-
 meeting.2019-05-09-17.01.log.html meeting today], cohosh suggested
 removing the proxy geoip information from /debug during the provisional
 deployment, and only storing it in metrics.log.

 I did this and a few other things to make it work better with our specific
 deployment: https://github.com/cohosh/snowflake/compare/geoip_squashed

 - the broker wasn't failing correctly if the hardcoded "metrics.log" file
 couldn't be opened so I added a command-line option to specify this file,
 or default to Stdout. I also made sure to LogFatal if the specified file
 can't be opened. This required a bit of refactoring.

 - Fixed the log output to not print an extra newline character

 - Removed the {{{if country != "" {} }}} condition and added the
 documentation as requested above

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29734#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online