[tor-bugs] #30166 [Applications/Tor Browser]: If custom bridges are specified, only use those bridges for connecting

[Tor Bug Tracker & Wiki]

#30166: If custom bridges are specified, only use those bridges for connecting
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-8.5-must,            |  Actual Points:
  TorBrowserTeam201905                           |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:13 gk]:


 > Alright here come some questions:
 >
 > 1) It seems de13672fe1ef6eb180edd4ec80f3f416f5d5c6b1 and
 30a7a83c5e715eb7ef739870bc0ff615ad52daeb fix the same bug (this one).
 Could you prepare a commit with both of those changes as the first of
 those commits does not fully fix the problem?
 Sure I'll get that fixed. I have been working off master, so I didn't want
 to rebase in case anyone else was using the library but now that we have
 brought in the code, I'll work off the branches with rebases.

 >
 > 2) What's the need for commit 7e77a5cd6c9ec609963e3b60b7838116cb8b37e2?
 (I guess we should at least mention the reason for that in the commit
 message)
 This may be an issue for further discussion. My idea has been to create a
 library for general use in the community so I wanted to keep the Android
 versions updated. Otherwise, we lock developers into older versions of
 Android Studio and dependencies, which makes adoption more difficult.

 The versions are isolated to the properties files so changes are easy. As
 long our patches for the versions still work, this seems a good
 compromise.

 >
 > 3) What's the deal with the TOPL libs in the repo given that we build
 those ourselves during the build?
 This is also related to general community use. I want this to work outside
 of tor-browser-build. Ideally, when things are stable (which looks very
 close), we will get the TOPL libraries pushed to a maven repo, rather than
 including them in the libs directory.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30166#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online