[tor-bugs] #30455 [Core Tor/Tor]: Does "make test-network-all" test every network twice?

[Tor Bug Tracker & Wiki]

#30455: Does "make test-network-all" test every network twice?
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  035-backport? 040-backport? chutney
     Severity:  Normal   |  easy
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 It appears that in fb32c522320430f, we added a second call to test-
 network.sh inside our test-network-all loop.  Now the code looks like
 this:

 {{{
         for f in $$flavors; do \
                 $(SHELL) $(top_srcdir)/test-driver --test-name $$f --log-
 file $(TEST_NETWORK_ALL_LOG_DIR)/$$f.log --trs-file
 $(TEST_NETWORK_ALL_LOG_DIR)/$$f.trs $(TEST_NETWORK_ALL_DRIVER_FLAGS)
 $(top_srcdir)/src/test/test-network.sh --flavor $$f $(TEST_NETWORK_FLAGS);
 \
                 $(top_srcdir)/src/test/test-network.sh
 $(TEST_NETWORK_WARNING_FLAGS); \
         done; \
 }}}

 I might be wrong, but it looks to me like we're calling test-network.sh
 twice in each loop: once through `test-driver`, and once directly.

 I'm not going to work on this till teor is back, though, since there are
 dragons here that I do not understand.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30455>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online