[tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,       |
  040-backport, postfreeze-ok, network-team-     |
  roadmap-2019-Q1Q2                              |
Parent ID:  #29995                               |         Points:  3
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 > <mikeperry> dgoulet: what do you think about what I did earlier in that
 case?
 (https://github.com/torproject/tor/pull/931/commits/bee7979e87d51735d2d5f746d69761d89d7dd928)
 > <dgoulet> mikeperry: yeah something like that but it needs to  call
 hs_circ_cleanup() for v3 only and the v2 stuff needs to ideally not be
 done there... so I think the place it needs to go is hs_common.c and then
 call the v2 or v3 specialized calls

 Hrmm, I am not sure how to differentiate the v2 vs v3 calls+data. What is
 the convention for that?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29034#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online