[tor-bugs] #30373 [Core Tor/Tor]: Most headers non-compliant with spec

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon May 6 13:56:10 UTC 2019


#30373: Most headers non-compliant with spec
-------------------------------------------+-------------------------------
 Reporter:  irl                            |          Owner:  (none)
     Type:  defect                         |         Status:  new
 Priority:  Medium                         |      Milestone:
Component:  Core Tor/Tor                   |        Version:  Tor:
                                           |  unspecified
 Severity:  Normal                         |     Resolution:
 Keywords:  bandwidth-file-spec, tor-spec  |  Actual Points:
Parent ID:                                 |         Points:  1
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by juga):

 Replying to [comment:3 irl]:
 > Replying to [comment:1 juga]:
 > > Does it sounds fine that we just re-define `Keyword` and `KeywordChar`
 in the bandwidth file to include `_`?.
 > >
 > > I think we would need to increment the version though.
 >
 > I don't think the version needs changing, this is a "typo fix" in my
 mind. Anyone that has an implementation that works with the current sbws
 files is already complying with the change that we haven't made yet.

 A complying version is 1.0.0. A parser that is ignoring anything (as it
 should) that contains `_` will still parse the timestamp, which is the
 only required thing in 1.0.0.

 >
 > Keyword and KeywordChar are already defined, so I wouldn't want to cause
 confusion be re-defining them, even though it's a different spec people
 have ideas in their heads about what these mean.
 >
 > Maybe just a new `Key`:
 >
 > {{{Key ::= (KeywordChar | "_")+}}}

 I agree and that sounds good, for some reason i thought we were redefining
 something else, but checked and i don't think so.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30373#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list