[tor-bugs] #30359 [Core Tor/Stem]: Stem PEP8 compliant

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu May 2 21:43:08 UTC 2019


#30359: Stem PEP8 compliant
---------------------------+------------------------
 Reporter:  0xrichard      |          Owner:  atagar
     Type:  enhancement    |         Status:  new
 Priority:  Low            |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Minor          |     Resolution:
 Keywords:  dev            |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by 0xrichard):

 > Which of these do you strongly feel we should change and why?

 all, see:

 inore = E501,W504,F811,F821,W605,E402,F401,F405,E131,W503,E265,E999,F403

 > If you make a separate commit with this and repro steps for triggering
 the circular dependency bug I'd be happy to chat.

 don't put stuff in __init__

 > What benefit will that provide over what we presently have?

 flexibility

 I recently rewrote +/- 400 django unit tests to pytest, and yes, it's
 worth it

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30359#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list