[tor-bugs] #30173 [Core Tor/Tor]: Ensure circuit padding can be safely disabled from consensus

[Tor Bug Tracker & Wiki]

#30173: Ensure circuit padding can be safely disabled from consensus
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:  0.33
  padding, 041-proposed                          |
Parent ID:  #28634                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Hm, seems like CI is broken because of at least
 `src/core/or/circuitpadding.c:1111:1: error: no previous prototype for
 ‘circpad_is_padding_allowed’ [-Werror=missing-prototypes]` . Not sure
 if there are other errors too.

 I also let two other comments in the PR.

 After that, I think we are good to go.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30173#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online