[tor-bugs] #30286 [Core Tor/Tor]: pre-push git hook will warn about fixups for no reason
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu May 2 09:50:56 UTC 2019
#30286: pre-push git hook will warn about fixups for no reason
--------------------------------+------------------------------------
Reporter: asn | Owner: rl1987
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-ci git-scripts | Actual Points:
Parent ID: | Points: 0.2
Reviewer: | Sponsor:
--------------------------------+------------------------------------
Changes (by asn):
* status: needs_information => new
Comment:
Replying to [comment:3 rl1987]:
> Regarding "Github but not upstream" part, we can refrain from checking
commit titles when not pushing to upstream. See:
https://github.com/rl1987/tor/commit/d91deeee45c3433cc7dcaf1e67a84692420db870
>
> The second part is harder. To list commits that first appeared on branch
being pushed one needs to find out parent branch, which seems to require
some nasty looking code to make it work in general case. See:
> * https://stackoverflow.com/a/4649377
> * https://stackoverflow.com/questions/3161204/find-the-parent-branch-
of-a-git-branch
>
> Not sure the extra complexity cost makes it worthwhile?
I think we should at least do the `github but not upstream` part, because
right now we can't push stuff without dirty workarounds.
Not sure if the second part is worth doing indeed. Let's start with the
first and see how it goes?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30286#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list